[runtime][hip][cuda] Fix waiting on a semaphore on the host #17073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When waiting on a semaphore we first attempt to wait on a timepoint event on the dispatch stream.
This is not correct as the semaphore is signaled in a callback on the host stream when signaling that an action is complete.
This callback happens after the dispatch stream event, so the semaphore value may not be update yet.
The fix is to directly wait on the host semaphore and not on the dispatch stream event.
Also add a test that catches this failure.