Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime][hip][cuda] Fix waiting on a semaphore on the host #17073

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[runtime][hip][cuda] Fix waiting on a semaphore on the host #17073

merged 2 commits into from
Apr 17, 2024

Commits on Apr 17, 2024

  1. [runtime][hip][cuda] Fix waiting on a semaphore on the host 

    When waiting on a semaphore we first attempt to wait on a timepoint event on
the dispatch stream.
This is not correct as the semaphore is signaled in a callback on the host
stream when signaling that an action is complete.
This callback happens after the dispatch stream event, so the semaphore value
may not be update yet.

The fix is to directly wait on the host semaphore and not on the dispatch
stream event.

Also add a test that catches this failure.
    @sogartar
    sogartar committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8a55943 View commit details
    Browse the repository at this point in the history

  2. Fix comments

    @sogartar
    sogartar committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8f19425 View commit details
    Browse the repository at this point in the history