Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode, String internals #426

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

notFaceroll
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I review some words that should be revised.

@@ -1,172 +1,167 @@

# Unicode, String internals
# Unicode, detalhes internos de Strings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "das Strings" because "String" is singular and "Strings" plural.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings, both singular and plural, can be referenced with the preposition "de".

There are some examples of this in both singular and plural in the pt-br version of MDN docs - Strings

Copy link
Member

@nazarepiedady nazarepiedady Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we are not translating to Brazilian Portuguese, only Portuguese.

String translates directly to Sequência de Caracteres and Strings translates directly to Sequências de Caracteres, so we are not talking about the same thing.

To avoid confusion, I recommend reverting the translation to just use String instead of Strings.

```

As we already know, JavaScript strings are based on [Unicode](https://en.wikipedia.org/wiki/Unicode): each character is represented by a byte sequence of 1-4 bytes.
Como já sabemos, strings em JavaScript são baseadas em [Unicode](https://en.wikipedia.org/wiki/Unicode): cada caractere é representado por uma sequência de bytes de 1 a 4 bytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "já sabemos que, as Strings da JavaScript são baseadas no".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is also not necessary.

Since the word "linguagem" is omitted before "JavaScript", it can also be referred to with the preposition "em".

This can also be based on the pt-br version of MDN docs - Strings

Copy link
Member

@nazarepiedady nazarepiedady Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word linguagem is implied because JavaScript is a programming language.

And just because others do different does not make it right.


Because the `\xXX` notation supports only two hexadecimal digits, it can be used only for the first 256 Unicode characters.
Porque a notação `\xXX` suporta apenas dois dígitos hexadecimais, ela pode ser usada apenas para os primeiros 256 caracteres Unicode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should start by "uma vez que a notação".

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@notFaceroll
Copy link
Contributor Author

/done

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good enough to be applied.

@nazarepiedady
Copy link
Member

@Peruibeloko and @jonnathan-ls, could you review this to check if it is okay to pass?

Copy link
Contributor

@Peruibeloko Peruibeloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algumas mudanças rápidas, nada demais

```warn header="Advanced knowledge"
The section goes deeper into string internals. This knowledge will be useful for you if you plan to deal with emoji, rare mathematical or hieroglyphic characters, or other rare symbols.
```warn header="Conhecimento avançado"
Esta seção aprofunda nos detalhes internos das strings. Este conhecimento será útil se você planeja lidar com emojis, caracteres matemáticos raros, hieróglifos ou outros símbolos raros.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu odeio a palavra "hieróglifos" usada em diversos trechos que tratam de Unicode, sinto que é um pouco xenofóbico. Eu sempre traduzo por "logogramas" ou outros nomes mais apropriados.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peruibeloko, não é xenofóbico, é um termo muito usado na arqueologia.
Recomendo as pessoas a entenderem as coisas e dos porquês (se existirem) antes de partilharem opiniões sobre assuntos fora do seu domínio, mas geralmente se está fora do seu domínio não dê opiniões.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nazarepiedady sim, é um termo muito usado na arqueologia, mas nos trechos que me refiro, o autor não usa a palavra nesse sentido.

Repare que é possível ver pelo contexto, não só nesse artigo mas em outros também, que o terno hieróglifos está sendo usado no lugar de logogramas. Hieróglifos são especificamente os usados pelos egípcios antigos, logogramas são qualquer sistema de escrita que usa um único caractere para representar um morfema, palavra ou conceito.

Hieróglifos são um tipo de logograma, mais especificamente ideograma, já que usam representações visuais dos conceitos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peruibeloko entendo, obrigado pelo esclarecimento!
Mas agora, @nazarepiedady e @Peruibeloko, o que não ficou muito claro pra mim é: mantenho como está ou faço a alteração para "logograma"?

Copy link
Member

@nazarepiedady nazarepiedady Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notFaceroll, keep it as it is.


So the methods [String.fromCodePoint](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/fromCodePoint) and [str.codePointAt](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/codePointAt) were added in JavaScript to deal with surrogate pairs.
Então, os métodos [String.fromCodePoint](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/fromCodePoint) e [str.codePointAt](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/codePointAt) foram adicionados no JavaScript para lidar com pares substitutos.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sempre que possível, é bom usar o link para a MDN em pt-BR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notFaceroll, could you check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posso sim


They are essentially the same as [String.fromCharCode](mdn:js/String/fromCharCode) and [str.charCodeAt](mdn:js/String/charCodeAt), but they treat surrogate pairs correctly.
Eles são essencialmente os mesmos que [String.fromCharCode](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/fromCharCode) e [str.charCodeAt](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/charCodeAt), mas eles tratam pares substitutos corretamente.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O mesmo aqui

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pra já

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@notFaceroll
Copy link
Contributor Author

/done

@nazarepiedady
Copy link
Member

@Peruibeloko, @jonnathan-ls, could you review this pull request?

We need to review and apply all current pull request to leave the pull request section clean to receive new pull requests.

@nazarepiedady nazarepiedady merged commit bc56aba into javascript-tutorial:master Mar 24, 2024
1 check passed
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants