🐾 Add a fast Create Plan page - step 7 #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled form after an API error (new buttons visible)
Drawer before the changeUnnecessary scrollbar is displayed. The buttons are not visible. Drawer with selected VMs after the changeThe drawer wraps the items above the form which drags the whole table higher (only the namespace bar is left)
|
rszwajko
force-pushed
the
migrateBtnV15
branch
2 times, most recently
from
5026f2c
to
3a9ca56
Compare
yaacov
added
the
enhancement
yaacov
changed the title
rszwajko
force-pushed
the
migrateBtnV15
branch
from
3a9ca56
to
f886f44
Compare
ValidationsIncomplete mappingImplemented based on backend check as discussed here and here
Multiple NICs mapped to Pod Networking / NICs with empty NIC profile
Multiple NICs on the same networkThis is a special case of incorrect network setup - it may trigger |
rszwajko
force-pushed
the
migrateBtnV15
branch
3 times, most recently
from
640e540
to
e4fe64b
Compare
Changes: 1. improve layout by wrapping title and info alert with a drawer. Now the only component pushing the VM table down is the namespace bar. 2. disable all edits when create action is triggered a) for description items - hide pencil icon b) for form components - propagate isDisabled flag 3. remove 'Create and start' button 4. rename 'Create and edit' to 'Create' 5. re-generate storage map name in case of naming conflict 6. add advanced validations: a) NICs with empty network profile (oVirt only) b) VM has multiple NICs on the same network c) VM has multiple NICs mapped to Pod Networking d) VM has unmmaped networks e) VM has unmapped storages 7. display loading indicator(dots) until main queries are done 8. move/add responsibility to useFetchEffect() hook a) handle API errors from data queries b) handle loading state (skip dispatch) c) block queries when editing is done 9. move responsibility from action handlers to generic handler a) block processing actions when editing is done b) log actions with payload c) track if actions were dispatched (initial loading) Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
rszwajko
force-pushed
the
migrateBtnV15
branch
from
e4fe64b
to
3b70f66
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #801
Depends on #898
Changes:
the only component pushing the VM table down is the namespace bar.
a) for description items - hide pencil icon
b) for form components - propagate isDisabled flag
a) NICs with empty network profile (oVirt only)
b) VM has multiple NICs on the same network
c) VM has multiple NICs mapped to Pod Networking
d) VM has unmmaped networks
e) VM has unmapped storages
a) handle API errors from data queries
b) handle loading state (skip dispatch)
c) block queries when editing is done
a) block processing actions when editing is done
b) log actions with payload
c) track if actions were dispatched (initial loading)
Signed-off-by: Radoslaw Szwajkowski rszwajko@redhat.com