Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Add a fast Create Plan page - step 7 #899

Merged
merged 1 commit into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. Add a fast Create Plan page - step 7

    Changes:
    1. improve layout by wrapping title and info alert with a drawer. Now
       the only component pushing the VM table down is the namespace bar.
    2. disable all edits when create action is triggered
       a) for description items - hide pencil icon
       b) for form components - propagate isDisabled flag
    3. remove 'Create and start' button
    4. rename 'Create and edit' to 'Create'
    5. re-generate storage map name in case of naming conflict
    6. add advanced validations:
       a) NICs with empty network profile (oVirt only)
       b) VM has multiple NICs on the same network
       c) VM has multiple NICs mapped to Pod Networking
       d) VM has unmmaped networks
       e) VM has unmapped storages
    7. display loading indicator(dots) until main queries are done
    8. move/add responsibility to useFetchEffect() hook
       a) handle API errors from data queries
       b) handle loading state (skip dispatch)
       c) block queries when editing is done
    9. move responsibility from action handlers to generic handler
       a) block processing actions when editing is done
       b) log actions with payload
       c) track if actions were dispatched (initial loading)
    
    Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
    rszwajko committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3b70f66 View commit details
    Browse the repository at this point in the history