-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[de] 24.10. #9524
Merged
Merged
[de] 24.10. #9524
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1922,8 +1922,8 @@ To ignore a remote rule match, set the <marker> so that it exactly covers the te | |
</rule> | ||
</rulegroup> | ||
|
||
<rulegroup id="AI_DE_GGEC_UNNECESSARY_PUNCTUATION_PERIOD__PERIOD__PERIOD.*" name=""><!-- gGEC wants to remove the 3 dots and start the sentence with a capital letter--> | ||
<rule> | ||
<rulegroup id="AI_DE_GGEC_UNNECESSARY_PUNCTUATION_PERIOD__PERIOD__PERIOD.*" name=""> | ||
<rule><!-- gGEC wants to remove the 3 dots and start the sentence with a capital letter--> | ||
<pattern> | ||
<token>.</token> | ||
<token>.</token> | ||
|
@@ -1935,5 +1935,28 @@ To ignore a remote rule match, set the <marker> so that it exactly covers the te | |
</rule> | ||
</rulegroup> | ||
|
||
<rulegroup id="AI_DE_GGEC_REPLACEMENT_ORTHOGRAPHY_LOWERCASE" name=""> | ||
<rule><!-- gGEC wants to capitalize the word, but the brand name is lowercase --> | ||
<pattern case_sensitive="yes"> | ||
<token>mydays</token> | ||
</pattern> | ||
<example correction="">Finde bei <marker>mydays</marker> eine riesige Auswahl an originellen Geschenkideen für alle Anlässe.</example> | ||
</rule> | ||
</rulegroup> | ||
|
||
<rulegroup id="AI_DE_GGEC_UNNECESSARY_ORTHOGRAPHY_SPACE" name=""> | ||
<rule><!-- FP --> | ||
<pattern> | ||
<token>von</token> | ||
<token>Seiten</token> | ||
<token min="0">dritter</token> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. gibt es hier vlt noch mehr? "von Seiten anderer" etc.? |
||
<token min="0">zu</token> | ||
<token postag_regexp="yes" postag="VER.*" /> | ||
</pattern> | ||
<example correction="">Die Werbung wird <marker>von Seiten</marker> blockiert.</example> | ||
<example correction="">Diese fremden Inhalte stammen weder von uns noch haben wir die Möglichkeit, den Inhalt <marker>von Seiten</marker> Dritter zu beeinflussen.</example> | ||
</rule> | ||
</rulegroup> | ||
|
||
</category> | ||
</rules> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hier gibt es bestimmt ganz viele Fälle, ob man dafür eine Liste anlegen könnte?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, die Regel kann man dann ja einfach erweitern 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aber dann hätte man ja ganz viele (unendliche) Regeln, wäre eine ENTITY nicht besser? wenn das geht
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man könnte ja auch einfach eine regexp draus machen..