Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] 24.10. #9524

Merged
merged 4 commits into from
Oct 24, 2023
Merged

[de] 24.10. #9524

merged 4 commits into from
Oct 24, 2023

Conversation

Luisa-LT
Copy link
Collaborator

gGEC APs + added words

@Luisa-LT Luisa-LT requested a review from St-ac-y October 24, 2023 14:02
<rulegroup id="AI_DE_GGEC_REPLACEMENT_ORTHOGRAPHY_LOWERCASE" name="">
<rule><!-- gGEC wants to capitalize the word, but the brand name is lowercase -->
<pattern case_sensitive="yes">
<token>mydays</token>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier gibt es bestimmt ganz viele Fälle, ob man dafür eine Liste anlegen könnte?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, die Regel kann man dann ja einfach erweitern 👍

Copy link
Contributor

@St-ac-y St-ac-y Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aber dann hätte man ja ganz viele (unendliche) Regeln, wäre eine ENTITY nicht besser? wenn das geht

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man könnte ja auch einfach eine regexp draus machen..

<pattern>
<token>von</token>
<token>Seiten</token>
<token min="0">dritter</token>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gibt es hier vlt noch mehr? "von Seiten anderer" etc.?

@Luisa-LT Luisa-LT merged commit 48442e0 into languagetool-org:master Oct 24, 2023
2 checks passed
@Luisa-LT Luisa-LT deleted the 24.10_ branch October 24, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants