Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard VS configuration in CMake file with MSVC #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giordano
Copy link

The CMake file is implicitly assuming that Microsoft Visual Studio is the only compiler for Windows, which is of course false. The Microsoft Visual Studio-specific configuration should be guarded with MSVC. This change makes it possible to build YAJL with MinGW for example, see this patch in the MINGW-packages repository.

The CMake file is implicitly assuming that Microsoft Visual Studio is the only compiler for Windows, which is of course false.  The Microsoft Visual Studio-specific configuration should be guarded with [`MSVC`](https://cmake.org/cmake/help/latest/variable/MSVC.html).  This change makes it possible to build YAJL with MinGW for example, see [this patch](https://github.com/msys2/MINGW-packages/blob/11cf0665cfd6a4cf70fea61f60374a5dc07ee5f3/mingw-w64-yajl/01-fix-compiler.patch) in the MINGW-packages repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant