Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard VS configuration in CMake file with MSVC #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard VS configuration in CMake file with MSVC #228

wants to merge 1 commit into from

Commits on Apr 12, 2020

  1. Guard VS configuration in CMake file with MSVC 

    The CMake file is implicitly assuming that Microsoft Visual Studio is the only compiler for Windows, which is of course false.  The Microsoft Visual Studio-specific configuration should be guarded with [`MSVC`](https://cmake.org/cmake/help/latest/variable/MSVC.html).  This change makes it possible to build YAJL with MinGW for example, see [this patch](https://github.com/msys2/MINGW-packages/blob/11cf0665cfd6a4cf70fea61f60374a5dc07ee5f3/mingw-w64-yajl/01-fix-compiler.patch) in the MINGW-packages repository.
    @giordano
    giordano authored Apr 12, 2020
    Configuration menu
    Copy the full SHA
    091211a View commit details
    Browse the repository at this point in the history