Fix some bugs and enable setuptools install #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BT:
zippedFiles = dict((file.path, file) for file in zip.readZip(zipFile))
File "/usr/lib/python3.7/site-packages/fwtool/zip/__init__.py", line 44, in readZip
contents = zip.open(member)
File "/usr/lib/python3.7/zipfile.py", line 1458, in open
self._fpclose, self._lock, lambda: self._writing)
File "/usr/lib/python3.7/zipfile.py", line 699, in __init__
self.seekable = file.seekable
AttributeError: 'FilePart' object has no attribute 'seekable'
Fixes the following exceptions: * ModuleNotFoundError: No module named 'cffi' * ModuleNotFoundError: No module named 'tempfile' * ModuleNotFoundError: No module named 'Crypto'
* Rename fwtool.py to fw-tool to not messup pythons import system (not a good idea to have the same name on a script and a module) * Move decives.yml in to fwtool module * Rename Licence to conform to python packaging guide lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs that i experienced and restructured the package to be installable by setuptools.