Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Detail API lookup by Mapbox ID #298

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Aug 20, 2024

Description

Fixes SSDK-569

  • Add SearchEngine.select(mapboxID: String, options: DetailsOptions) to invoke a retrieve/ API endpoint call to retreive details from a Mapbox ID.
  • Add DetailsOptions to configure Mapbox ID retrieves for: AttributeSets, Language, Worldview

Checklist

  • Update CHANGELOG

… Mapbox ID

- Refine documentation
- SearchEngine.search and SearchEngine.select are a two-step combination
- Stop wrapping SearchEngine.retrieve(mapboxID:) in an over-loaded SearchEngine.select wrapper
- Mark SearchEngine.retrieve(mapboxID:) public as the main and only way to query Details API / Mapbox ID
@aokj4ck aokj4ck marked this pull request as ready for review August 23, 2024 20:00
@aokj4ck aokj4ck requested review from a team as code owners August 23, 2024 20:00
@aokj4ck aokj4ck marked this pull request as draft August 26, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant