Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Detail API lookup by Mapbox ID #298

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add Detail API lookup by Mapbox ID #298

wants to merge 13 commits into from

Commits on Aug 20, 2024

  1. Bonus: add testRetrieveDetailsAllAttributes test

    @aokj4ck
    aokj4ck committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7fb6620 View commit details
    Browse the repository at this point in the history

  2. WIP: Begin adding retrieve(mapboxID:) Details function

    @aokj4ck
    aokj4ck committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3013d8d View commit details
    Browse the repository at this point in the history

  3. Add testRetrieveDetailsByMapboxId unit test

    @aokj4ck
    aokj4ck committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    317d904 View commit details
    Browse the repository at this point in the history

  4. Update test function invocation

    @aokj4ck
    aokj4ck committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e170bb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'main' of github.com:mapbox/mapbox-search-ios into SSDK-… 

    …569-add-Detail-API-lookup-by-mapbox_id
    @aokj4ck
    aokj4ck committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    503837f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. SearchEngine.retrieve(mapboxID:) is now the canonical way to query by… 

    … Mapbox ID

- Refine documentation
- SearchEngine.search and SearchEngine.select are a two-step combination
- Stop wrapping SearchEngine.retrieve(mapboxID:) in an over-loaded SearchEngine.select wrapper
- Mark SearchEngine.retrieve(mapboxID:) public as the main and only way to query Details API / Mapbox ID
    @aokj4ck
    aokj4ck committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    098f545 View commit details
    Browse the repository at this point in the history

  2. Begin adding mocked response test, begin correcting live-API tests fo… 

    …r retrieve(mapboxID:)
    @aokj4ck
    aokj4ck committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d2907b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'main' of github.com:mapbox/mapbox-search-ios into SSDK-… 

    …569-add-Detail-API-lookup-by-mapbox_id
    @aokj4ck
    aokj4ck committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e9cad76 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests for retrieve(mapboxID:) details api

    @aokj4ck
    aokj4ck committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    50d8e4b View commit details
    Browse the repository at this point in the history

  3. Update test for CI

    @aokj4ck
    aokj4ck committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6033200 View commit details
    Browse the repository at this point in the history

  4. Update for CI

    @aokj4ck
    aokj4ck committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9912d94 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'main' of github.com:mapbox/mapbox-search-ios into SSDK-… 

    …569-add-Detail-API-lookup-by-mapbox_id
    @aokj4ck
    aokj4ck committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    006564e View commit details
    Browse the repository at this point in the history

  2. Fix array-out-of-bounds access in SearchResultSuggestionImpl, fill in… 

    … TODO with ticket number
    @aokj4ck
    aokj4ck committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8ac31d0 View commit details
    Browse the repository at this point in the history