fix(kps): Remove duplicate apiserver / unused keepalived target (2.4) #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ig (#1483) * fix(kps): Remove duplicate apiserver scrapeconfig It looks like the KPS chart already defines a servicemonitor which scrapes the apiserver metrics. Our additional scrapeconfig definition is resulting in scraping the same apiserver targets and generating duplicate metrics. We can remove our scrape config and rely on the chart created servicemonitor. * fix(kps): Remove unnecessary keepalived scrape target (cherry picked from commit 90b170c)
2 tasks
gracedo
approved these changes
Aug 16, 2023
gracedo
added
ready-for-review
ok-to-test
gracedo
changed the title
gracedo
changed the title
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter
github-actions
bot
added
the
size/M
gracedo
changed the title
cwyl02
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease-2.4:Questions ?
Please refer to the Backport tool documentation