Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kps): Remove duplicate apiserver / unused keepalived target (2.4) #1491

Merged
merged 3 commits into from
Aug 17, 2023
Merged

fix(kps): Remove duplicate apiserver / unused keepalived target (2.4) #1491

merged 3 commits into from
Aug 17, 2023

Commits on Aug 16, 2023

  1. fix(kps): Remove duplicate apiserver and unused keepalived scrapeconf… 

    …ig (#1483)

* fix(kps): Remove duplicate apiserver scrapeconfig

It looks like the KPS chart already defines a servicemonitor which
scrapes the apiserver metrics. Our additional scrapeconfig definition is
resulting in scraping the same apiserver targets and generating
duplicate metrics. We can remove our scrape config and rely on the chart
created servicemonitor.

* fix(kps): Remove unnecessary keepalived scrape target

(cherry picked from commit 90b170c)
    @gracedo
    gracedo committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    df75fda View commit details
    Browse the repository at this point in the history

  2. ci: Validate PR title length instead of commit (#1433) 

    * ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter
    @gracedo
    gracedo committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c62e72e View commit details
    Browse the repository at this point in the history

  3. ci(gitlint): Increase body-max-line-length

    @gracedo
    gracedo committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    7fa35a2 View commit details
    Browse the repository at this point in the history