-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spades 3.12 #114
Spades 3.12 #114
Conversation
merged reads are used sperately by spades. added possibility to drop normalization
made filtering optional not tested
Hi Silas, Sorry, also a question here, I ran the new atlas with spades 3.12; and I wanted to choose the k-mers, 21,33,55 and 77. Although I specified this in the yaml file: it only does 21,33,55. I wanted to try 77 for 2x250 Illumina reads, and because we have high abundance of certain strains, so longer kmers might maybe improve assembly. Hope this is a quick fix, that the spades command reads in the parameters given here, and not his default. Thanks, Spades#------------ |
I corrected it on the master branch. Tell me if you see improvements. |
Hi Silas, I tried it, and it works, it runs all the specified k's up to 127 I tried! Thanks. The only issue I run into (with both v1.0.33 and v1.0.34), and it was not in the v1.0.32, is that MaxBin 2.2.1 stops Atlas when it reaches a sample where no decent bin was found, so it can't find the marker gene. It quits everything, terminating with an error, instead of moving on to the next. Error in maxbin2.log of sample AA3s MaxBin 2.2.1 |
I had a similar problem #29 but don't know how to solve it. If you can't find not enough marker genes, you probably have to check your assembly... I didn't change anything in the maxbin rule between v1.022 . You can add the command line uption |
Thank you for your genome stats. I should also try to use higher numbers of k for the spades assembly. dRep only chooses the best genome, It doesn't "merge" genomes, does it? |
Ok, Yes, dRep uses gANI and mash to calculate the genome-genome distance, it doesn't merge, if I understood well. And then selects the best bin. The advantage is that is does allow comparing bins from different assemblies. DAS Tool is similar and performs an aggregation step and starts from scaffold2bin.tsv and a contig file, from 1 assembly. It can be interesting, like the ability to run not only MaxBin2 (now in atlas), but the ability to choose e.g. also CONCOCT, MetaBAT, and tetraESOMs binning tools and then run DAS Tool to get the high quality, de-replicated bin, and start annotating these bins. That would be great. It is more automated and can save time for manual bin curation in Anvio, which can still come downstream of all this. Sofie |
Actually, I've implemented Concoct and Metabat in Atlas, the "mags"-
branch. but the results are much worse at least on the Cami data, that I
don't think it's the best ides to make as many bins as possible and then
merge them.
…On Thu, Jun 28, 2018 at 9:32 AM Sofie8 ***@***.***> wrote:
Ok, Yes, dRep uses gANI and mash to calculate the genome-genome distance,
it doesn't merge, if I understood well. And then selects the best bin. The
advantage is that is does allow comparing bins from different assemblies.
DAS Tool is similar and performs an aggregation step and starts from
scaffold2bin.tsv and a contig file, from 1 assembly. It can be interesting,
like the ability to run not only MaxBin2 (now in atlas), but the ability to
choose e.g. also CONCOCT, MetaBAT, and tetraESOMs binning tools and then
run DAS Tool to get the high quality, de-replicated bin, and start
annotating these bins. That would be great. It is more automated and can
save time for manual bin curation in Anvio, which can still come downstream
of all this.
Sofie
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#114 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHLK2ucgC7kOrxSevMpRdWk3WSfB0-87ks5uBIZ4gaJpZM4UWO6F>
.
|
Oh ok, and how can I specify this exactly, to run Concoct and Metabat in Atlas? Maybe you are right, that merging doesn't improve too much, but the results from the paper looked very promising so I thought to give it a try. It can only be as good as your assemblies though, and the quality of the individual binning tools, but well. |
Have a look at #87 I implemented concoct and metabat on the I suggest you download the git repository in another folder, to have two versions of Atlas.
change to the development branch:
I suggest directly to access directly the Snakefile. I din’t finalised everything in the setup.py. instead of
|
@Sofie8 |
Hi Silas, I performed the things you wrote above, but I get syntax error, and I checked the output file I am writing to that is consistent in my yaml and .pbs script. SyntaxError: |
Ah, the old scripbate not compatible with snakemake v5. If you want you can
downgrade snakemake to v4.7. ma be. Lstter this week I've time to updatr
the mags branch.
…On Jul 8, 2018 13:58, "Sofie8" ***@***.***> wrote:
Hi Silas,
I performed the things you wrote above, but I get syntax error, and I
checked the output file I am writing to that is consistent in my yaml and
.pbs script.
SyntaxError:
Not all output, log and benchmark files of rule error_correction contain
the same wildcards. This is crucial though, in order to avoid that two or
more jobs write to the same file.
File "/vsc-hard-mounts/leuven-data/314/vsc31426/miniconda3/envs/
atlasmags/atlas/atlas/Snakefile", line 179, in
File "/vsc-hard-mounts/leuven-data/314/vsc31426/miniconda3/envs/
atlasmags/atlas/atlas/rules/assemble.snakefile", line 128, in
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#114 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHLK2rMcAEbsu5cTI8fRS4W75I5la-PXks5uEfP9gaJpZM4UWO6F>
.
|
Hi Silas, Other question, prokka was updated some days ago (tseemann/prokka#320), and now it breaks my atlas runs: When I reinstall prokka and run outside atlas, it works, but not within atlas. Can we edit this in the snakemake file, that it retrieves only the last, working prokka version? |
To select metabat as binner:
|
@Sofie8 @brwnj Do you think it's a good Idea to use metabat on single samples. It was generated for binnining based on abundances in different samples. But for example in https://www.nature.com/articles/s41564-017-0012-7 they used metabat on sinlge samples. |
Hi Silas, I ran concoct, and in the log it says 100 % complete, I see combined_contigs.fasta, but is there also the output of bins? or scaffolds2bins.tsv? I attach you my .yaml and log files. I would like to run afterwards Dastool: The samples I have are actually 12 fractions of the same sample, but with different GC content because the DNA underwent GC density fractionation. My co-assemblies are thus still originating from 1 sample, but GC-normalised kind of. Thanks for your prompt replies. |
Ads spades 3.12, which handles merged reads separately.
Added "loose parameters"
add options to individually toggle:
added pythonic symlinks to reduce memory storage.