Added slot:analyte_category and Enum: AnalyteCategoryEnum
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynnz22
approved these changes
Dec 12, 2023
| @@ -1729,6 +1732,26 @@ classes: | |||
| - https://casrai.org/credit/ | |||
|
|
|||
| enums: | |||
There was a problem hiding this comment.
can you add the descriptions for the permissible values for the AnalyteCategoryEnum? Otherwise, I think this is good!
There was a problem hiding this comment.
@turbomam I disagree with this. We should really get out of the habit of adding things without descriptions with the intent of going back to add descriptions.
We want to wrap up ALL the PRs and changes in this for this week so as soon as we're back from the holidays we can start focusing on the migrations and integration.
So the fork needs to be frozen by the end of the week. Can we get these descriptions in ASAP?
mslarae13
changed the title
mslarae13
added
the
migration-needed
This was referenced Jan 6, 2024
brynnz22
added
the
migrator-written
brynnz22
changed the title
analyte_category and Enum: AnalyteCategoryEnum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collections requiring migration:
Workflow migration