Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slot:analyte_category and Enum: AnalyteCategoryEnum #4

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Dec 12, 2023

Collections requiring migration:

  • omics_processing_set (will this set be renamed?

Workflow migration

  • update workflows referencing omics type

@aclum aclum requested a review from brynnz22 December 12, 2023 20:00
@turbomam turbomam merged commit 9165ad0 into main Dec 12, 2023
2 checks passed
Copy link
Collaborator

@brynnz22 brynnz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, going to approve this, but as Mark said on slack - someone can create a new issue to modify the descriptions in the future.

@@ -1729,6 +1732,26 @@ classes:
- https://casrai.org/credit/

enums:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the descriptions for the permissible values for the AnalyteCategoryEnum? Otherwise, I think this is good!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbomam I disagree with this. We should really get out of the habit of adding things without descriptions with the intent of going back to add descriptions.

We want to wrap up ALL the PRs and changes in this for this week so as soon as we're back from the holidays we can start focusing on the migrations and integration.
So the fork needs to be frozen by the end of the week. Can we get these descriptions in ASAP?

@brynnz22 brynnz22 deleted the analyte_category branch December 12, 2023 23:30
@mslarae13 mslarae13 changed the title Analyte category Added slot:analyte_category and Enum: AnalyteCategoryEnum Dec 19, 2023
@mslarae13 mslarae13 added the migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. label Dec 19, 2023
@brynnz22 brynnz22 added the migrator-written a migrator script has been written addressing the PR/schema change label Jan 25, 2024
@brynnz22 brynnz22 changed the title Added slot:analyte_category and Enum: AnalyteCategoryEnum Added slot:analyte_category and Enum: AnalyteCategoryEnum Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. migrator-written a migrator script has been written addressing the PR/schema change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants