Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define JSON schema's Type property as a flaggable enum to allow storing multiple values #1897

Merged
merged 19 commits into from
Oct 31, 2024
Merged

Define JSON schema's Type property as a flaggable enum to allow storing multiple values #1897

merged 19 commits into from
Oct 31, 2024

Commits on Oct 28, 2024

  1. Define JSON schema type as a flaggable enum to allow storing strings … 

    …or array of strings
    @MaggieKimani1
    MaggieKimani1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    79f3e94 View commit details
    Browse the repository at this point in the history

  2. Implement helper methods for switching between enum types and their e… 

    …quivalent identifiers
    @MaggieKimani1
    MaggieKimani1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8c9047f View commit details
    Browse the repository at this point in the history

  3. Refactor tests to reflect change

    @MaggieKimani1
    MaggieKimani1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2e03505 View commit details
    Browse the repository at this point in the history

  4. Update API interface

    @MaggieKimani1
    MaggieKimani1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d0fb2c7 View commit details
    Browse the repository at this point in the history

  5. Resolve merge conflicts

    @MaggieKimani1
    MaggieKimani1 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    42614be View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Fix failing tests

    @MaggieKimani1
    MaggieKimani1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    314880d View commit details
    Browse the repository at this point in the history

  2. code cleanup

    @MaggieKimani1
    MaggieKimani1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b2e1026 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/release/2.0.0' into mk/define-js… 

    …on-schema-type-as-enum
    @MaggieKimani1
    MaggieKimani1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    924ff0d View commit details
    Browse the repository at this point in the history

  4. Remove JsonSchemaType.Any type

    @MaggieKimani1
    MaggieKimani1 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    56c47cb View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add condition to check whether the flag matches the type before appen… 

    …ding it to a list; write string values
    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5af79d4 View commit details
    Browse the repository at this point in the history

  2. Add test for sample document with 3.1 features

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e12301c View commit details
    Browse the repository at this point in the history

  3. throw OpenApiException for it to be caught gracefully and appended to… 

    … diagnostics
    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e13fb01 View commit details
    Browse the repository at this point in the history

  4. Fix string formatting

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2e2ad57 View commit details
    Browse the repository at this point in the history

  5. Fix failing tests

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    656259a View commit details
    Browse the repository at this point in the history

  6. Update src/Microsoft.OpenApi/Models/OpenApiSchema.cs 

    Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com>
    @MaggieKimani1 @andrueastman
    MaggieKimani1 and andrueastman authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    07987ae View commit details
    Browse the repository at this point in the history

  7. Convert the JsonSchemaType helper methods to extensions

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3abe36c View commit details
    Browse the repository at this point in the history

  8. Add null check for type; simplify condition to verify flag has been set

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    38954dc View commit details
    Browse the repository at this point in the history

  9. Clean up tests

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b806323 View commit details
    Browse the repository at this point in the history

  10. Add null check

    @MaggieKimani1
    MaggieKimani1 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5eb0010 View commit details
    Browse the repository at this point in the history