C# signatures for new operators #713
Conversation
Implement correct C# method signature output for the newer operators that currently aren't implemented: unsigned right shift and all of the checked operators.
@nickwalkmsft The automatic trigger stops working somehow. As a workaround, you can run it manually in https://ceapex.visualstudio.com/Engineering/_build/results?buildId=1868434&view=results and enter your branch name. |
|
@huangmin-ms bummer, both this and #712 failed on compilation errors. It looks like the build uses .NET6/C#10, but checked user-defined operators weren't added until .NET7/C#11, and ref readonly parameters in .NET8/C#12. I don't think the actual implementation changes require newer versions, but the test cases actually use the newer language features, and so they don't compile in the build. What does it take to update the platform version used to compile and run mdoc? I imagine it has the potential to require some breakfixes, updates to the runtime environments used in the .NET pipelines that run mdoc, etc. |
|
For this PR, the compile error is caused by the I downloaded the latest mono and be able to reproduce this issue in local. To get rid of this in the future, we might need to replace all For #712, I upgraded pipeline sdk to 6.x to 8.x and the compilation error is gone. But seems the build result is also changed and we need to fix that. https://ceapex.visualstudio.com/Engineering/_build/results?buildId=1880166&view=logs&j=15dfcb1a-0989-5cf6-3160-3e181e44de87&t=ee259841-8374-5502-dbdb-28d76f0fa540 |
|
Thanks for digging on this @huangmin-ms! I admittedly didn't spend much time looking at the build, I just set up a mostly-working dev environment using VS2022 locally and worked on the code from there, so it doesn't surprise me that there are build-related problems. There's no hurry for these items, they can remain at their current priority, so please don't feel there's any rush to resolve the issues. Thanks! |
Work items:
Implement correct C# method signature output for the newer operators that currently aren't implemented: unsigned right shift and all of the checked operators.
Added unit tests and tested locally against the types mentioned in the work items (BigInteger and Int128).
As with #710, I was unable to get C++ tests running, but nothing in that codepath should be affected.