Apply for export-ignore towards better release packages #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used as a dependency in other projects, we don't want the release packages to include any development file. This includes CI files, test files, docs... This is useful to both: - Reduce the package sizes noticeably. - Ensure that composer, by default, (--prefer-dist) doesn't include them. If anybody prefers to get the complete version they always can use --prefer-source or clone the repository. This is considered good practice, as far as there can be problems with tests and other stuff when the dependencies include everything.
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
=========================================
Coverage 96.30% 96.30%
Complexity 497 497
=========================================
Files 21 21
Lines 1407 1407
=========================================
Hits 1355 1355
Misses 52 52 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For the records, I've faced with this problem with this (draft) pull request: moodlehq/moodle-local_codechecker#221 There, you can see how Ciao :-) |
stronk7
added a commit
to stronk7/moodle-local_codechecker
that referenced
this pull request
Sep 24, 2023
This step will be needed until this PR: moodlehq/moodle-cs#69 is merged and released. Then we can get rid of it. Note the reason is that phpunit finds the tests under vendor and tries to execute them. As far as moodle-cs is now just a dependency we don't want it to contain any developing code (ci, tests, docs...) in its distribution form.
stronk7
added a commit
to stronk7/moodle-local_codechecker
that referenced
this pull request
Sep 24, 2023
This step will be needed until this PR: moodlehq/moodle-cs#69 is merged and released. Then we can get rid of it. Note the reason is that phpunit finds the tests under vendor and tries to execute them. As far as moodle-cs is now just a dependency we don't want it to contain any developing code (ci, tests, docs...) in its distribution form.
andrewnicols
approved these changes
Sep 24, 2023
|
Tatata! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used as a dependency in other projects, we don't want the release packages to include any development file. This includes CI files, test files, docs...
This is useful to both:
This is considered good practice, as far as there can be problems with tests and other stuff when the dependencies include everything.