Move to composer based deps #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to keep them updated with composer. Way easier for a plugin that is going to fade out, now that we have the phpcs standard into its own (moodle-cs) repo.
stronk7
force-pushed
the
move_to_composer_based_deps
branch
from
d306885
to
db1567c
Compare
Also, raise the min supported PHP version to PHP 7.4 (Moodle 3.8.3 and up), this will enable us to update code in various places, in this plugin and others.
Describe the new steps needed to update the components (basically to updating moodle-cs), and update the thirdpartylibs.xml entries to point to the new location in the vendor directory (that also makes them to be ignored by codechecker itself). Special note about the phpcompatibility dev version that we are using and we'll be able to remove it once we switch to stable releases. Update phpunit configuration to avoid any coverage within the vendor dir.
This step will be needed until this PR: moodlehq/moodle-cs#69 is merged and released. Then we can get rid of it. Note the reason is that phpunit finds the tests under vendor and tries to execute them. As far as moodle-cs is now just a dependency we don't want it to contain any developing code (ci, tests, docs...) in its distribution form.
stronk7
force-pushed
the
move_to_composer_based_deps
branch
from
db1567c
to
25f176b
Compare
This was referenced Sep 25, 2023
|
Self merging, so we can test everything in place and apply for some changes in some other tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to keep them updated with composer. Way easier
for a plugin that is going to fade out, now that we have the
phpcs standard into its own (moodle-cs) repo.
Also, raise the min supported PHP version to PHP 7.4
(Moodle 3.8.3 and up), this will enable us to update
code in various places, in this plugin and others.
Once this is approved... it will be released as version 5.0.0 and
Moodle requirements will be raised to 3.8.3 (the very first version
of Moodle supporting PHP 7.4). The 4.x series won't get more
updates.
Installation instructions and
thirdpartylibs.xmlhave been updated toexplain and point to the new places where dependencies are installed.
Note that there is an extra commit (the last one), that is required
because the tests in some dependencies do conflict
with local_codechecker own ones. We will need to apply that
manual removal of tests until this PR is released in
moodle-cs:moodlehq/moodle-cs#69