Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the libonig5 to the Travis packages to install #255

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Nov 4, 2023

For some strange reason, travis has started to fail with PHP 8.2 with error:

php: error while loading shared libraries: libonig.so.5

It was not happening few days ago. Searching out there it seems that the fix is as simple as apt-installing that library.

It's incredible that they don't have that implemented in their environments and things like this need to be installed manually.

Any way, fixed in our own Travis test and also in the template and docs.

For some strange reason, travis has started to fail with
PHP 8.2 with error:

php: error while loading shared libraries: libonig.so.5

It was not happening few days ago. Searching out there it
seems that the fix is as simple as apt-installing that library.

It's incredible that they don't have that implemented in their
environments and things like this need to be installed manually.

Any way, fixed in our own Travis test and also in the template
and docs.
@stronk7 stronk7 mentioned this pull request Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #255 (2690611) into master (10674c0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #255   +/-   ##
=========================================
  Coverage     84.63%   84.63%           
  Complexity      694      694           
=========================================
  Files            74       74           
  Lines          2148     2148           
=========================================
  Hits           1818     1818           
  Misses          330      330           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@paulholden paulholden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulholden paulholden merged commit d313896 into moodlehq:master Nov 7, 2023
19 checks passed
@stronk7 stronk7 deleted the fix_travis_libonig_problem branch November 7, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants