Feat: Translation in French of first part Manuel Three.js #23050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greggman does this look good to you? |
|
Well, um, I don't read French 😭. Things that stick out (1) These don't seem to be related to threejsfundamentals so I'm not sure what they are supposed to be like |
|
Oh sorry for the name of files, i change this soon as possible ^^. |
|
Sorry, it seems this PR got lost. The PR misses two changes in |
Mugen87
reviewed
Aug 19, 2022
| @@ -0,0 +1,108 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
|
Closing in favor of #24516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #18902
Description
This is a translation in french of first par Manuel Three.js