BUGFIX: Restore old Placeholder behavior to keep shown when focused #3864
Conversation
In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in #3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy. This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867 We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such.
|
Works as expected, though my cursor (In Vivaldi / Chrome) is at the end of the placeholder which is confusing:
In Safari it works as in your video. |
|
I looked bit into the latest CSS changes of the Placeholder view, but there was nothing special. So I adjusted the position. Now we have the cursor at the first position. Safari: Chrome: |
There was a problem hiding this comment.
For me, it works like I would expect it.
Thanks for taking care @mhsdesign 💙
|
Thanks for the adjustments ... i dared to try in firefox but well: 
The placeholder dropped out. Also on safari it doesnt blink anymore but the styling looks good at least. This obviously needs a bit more of love. Ill see how it behaves in CK-Editor 40 or something here #3863 just for testing ;) |
|
Hmm, ok the Firefox renders the |
To move the cursor to the first position, the placeholder text is moved backwards. Therefore, a change with a break is disadvantageous.
|
Tested the behavior in Firefox (132), Chrome (129) and Safari (18.0.1) and it behaves the same. chrome-ff.mp4 |
markusguenther
deleted the
bugfix/fix-placeholder-disappearing-on-focus
branch
|
Thank you so much for carrying this one @markusguenther <3 |
…eos#3864) * BUGFIX: Restore old Placeholder behavior to keep shown when focused In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in neos#3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy. This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867 We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such. * TASK: Move cursor before the placeholer * TASK: Hide break in placeholder context To move the cursor to the first position, the placeholder text is moved backwards. Therefore, a change with a break is disadvantageous. --------- Co-authored-by: Markus Günther <info@unikka.de>
In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in #3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy.
This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867
We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such.
before (placeholder might disappear fully and text is not editable unless clicking on another element)
Bildschirmaufnahme.2024-10-09.um.09.41.53.mov
after
Bildschirmaufnahme.2024-10-09.um.09.38.53.mov
What I did
How I did it
How to verify it