Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Restore old Placeholder behavior to keep shown when focused #3864

Merged
merged 3 commits into from
Oct 14, 2024

Commits on Oct 9, 2024

  1. BUGFIX: Restore old Placeholder behavior to keep shown when focused

    In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in #3558 we introduced a regression as that implementation would hide the placeholder while just clicking into.
    This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy.
    
     This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867
     We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such.
    mhsdesign committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cbea04a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    0b198a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. TASK: Hide break in placeholder context

    To move the cursor to the first position, the placeholder text is moved backwards. Therefore, a change with a break is disadvantageous.
    markusguenther committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a081cd6 View commit details
    Browse the repository at this point in the history