feat: port in use #6887
Open
feat: port in use #6887
+86
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nforms the user that this could be from a netlify function opening ports Co-authored-by: Thomas Lane <tlane25@users.noreply.github.com>
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com>
DanielSLew
requested changes
Oct 19, 2024
added 2 commits
October 22, 2024 16:19
Co-authored-by: Will <wconrad265@users.noreply.github.com>
Co-authored-by: Will <wconrad265@users.noreply.github.com>
|
This has been updated with a new type. |
DanielSLew
reviewed
Oct 23, 2024
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
When we were trying to push this commit, we kept having a prettier format error for this file. This is what it recommended that we do, to update to a lowercase doctype. From my understanding, there is no functional difference between the two.
| @@ -73,3 +73,11 @@ export type NetlifyOptions = { | |||
| state: StateConfig | |||
| frameworksAPIPaths: FrameworksAPIPaths | |||
| } | |||
|
|
|||
| export interface AddressInUseError extends Error { | |||
There was a problem hiding this comment.
I would just add this into the same error type as optional fields
There was a problem hiding this comment.
The Error type lives in ~external/38d21a27-4378-4895-a56a-d0fa5726a379/lib.es2022.error.d.ts. I think it's from a dependency/ external source.
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com> Co-authored-by: Thomas Lane <tlane25@users.noreply.github.com>
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This pull request addresses these issues found below
netlify dev#6840We (@tlane25) outline the problem in the comments in #6840.
This pull request adds better error handling for users who open a port for a serverless function.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)