-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port in use #6887
base: main
Are you sure you want to change the base?
feat: port in use #6887
Conversation
nforms the user that this could be from a netlify function opening ports Co-authored-by: Thomas Lane <tlane25@users.noreply.github.com>
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small nit about any
types.
Co-authored-by: Will <wconrad265@users.noreply.github.com>
Co-authored-by: Will <wconrad265@users.noreply.github.com>
This has been updated with a new type. |
@@ -1,4 +1,4 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -73,3 +73,11 @@ export type NetlifyOptions = { | |||
state: StateConfig | |||
frameworksAPIPaths: FrameworksAPIPaths | |||
} | |||
|
|||
export interface AddressInUseError extends Error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just add this into the same error type as optional fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Error
type lives in ~external/38d21a27-4378-4895-a56a-d0fa5726a379/lib.es2022.error.d.ts
. I think it's from a dependency/ external source.
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com> Co-authored-by: Thomas Lane <tlane25@users.noreply.github.com>
Co-authored-by: Thomas Lane <163203257+tlane25@users.noreply.github.com>
🎉 Thanks for submitting a pull request! 🎉
Summary
This pull request addresses these issues found below
netlify dev
#6840We (@tlane25) outline the problem in the comments in #6840.
This pull request adds better error handling for users who open a port for a serverless function.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)