-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port in use #6887
base: main
Are you sure you want to change the base?
feat: port in use #6887
Changes from all commits
4313041
6b62b1e
9bd658a
34b6bb4
9f4944c
de63e8d
50fd78e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<!DOCTYPE html> | ||
<!doctype html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,3 +73,11 @@ export type NetlifyOptions = { | |
state: StateConfig | ||
frameworksAPIPaths: FrameworksAPIPaths | ||
} | ||
|
||
export interface AddressInUseError extends Error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would just add this into the same error type as optional fields There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
code: 'EADDRINUSE' | ||
errno: number | ||
syscall: 'listen' | ||
address: string | ||
port: number | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we were trying to push this commit, we kept having a prettier format error for this file. This is what it recommended that we do, to update to a lowercase
doctype
. From my understanding, there is no functional difference between the two.