GroupNavigationItem: encode exported contact groups as UTF-8 #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
st3iny
approved these changes
Sep 2, 2024
|
/backport to stable6.1 |
|
/backport to stable6.0 |
|
/backport to stable5.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2365
Fix #946
Previously exported contact groups would be encoded either as
us-ascii, oriso-8859-1if they had umlauts or other special characters. I made all of them be exported asutf-8, as singular contacts are.The main issues with this were that when contact groups were encoded as
iso-8859-1they would have a weird character instead of umlauts and would bug out while importing.