Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupNavigationItem: encode exported contact groups as UTF-8 #4107

Merged
merged 1 commit into from
Sep 2, 2024
Merged

GroupNavigationItem: encode exported contact groups as UTF-8 #4107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/AppNavigation/GroupNavigationItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@

methods: {
/**
* @param groups

Check warning on line 139 in src/components/AppNavigation/GroupNavigationItem.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "groups" description
* @param groupId

Check warning on line 140 in src/components/AppNavigation/GroupNavigationItem.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "groupId" description
*/
isInGroup(groups, groupId) {
return groups.includes(groupId)
Expand Down Expand Up @@ -227,7 +227,8 @@
async downloadVcardPromise(vcardPromise) {
vcardPromise.then(response => {
const filename = moment().format('YYYY-MM-DD_HH-mm') + '_' + response.groupName + '.vcf'
download(response.data, filename, 'text/vcard')
const content = 'data:text/plain;charset=utf-8,' + window.encodeURIComponent(response.data)
download(content, filename, 'text/vcard')
})
},

Expand All @@ -235,7 +236,7 @@
* Open mailto: for contacts in a group
*
* @param {object} group of contacts to be emailed
* @param {string} mode

Check warning on line 239 in src/components/AppNavigation/GroupNavigationItem.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "mode" description
*/
emailGroup(group, mode = 'to') {
const emails = []
Expand Down
Loading