Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt version backend to new features #2543

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Adapt version backend to new features #2543

merged 1 commit into from
Sep 7, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 6, 2023 •
edited
Loading

Adapt the version backend to the new files versions feature.

New

  • Support naming a version
  • Support deleting a version
  • Adds DB table to store version infos
  • Fix version creation that was using the current time instead of the version mtime
  • Adapt LazyFolder to new FileInfo interface make Node::getParent lazy server#38150

Todo

  • Test version import from previous versions
  • Check tests

Fix nextcloud/server#39138
Needs nextcloud/server#40296

@artonge artonge added bug enhancement 3. to review Items that need to be reviewed php Items related to PHP updates and code issues feature: versions Items related to file versioning labels Sep 6, 2023
@artonge artonge added this to the Nextcloud 28 milestone Sep 6, 2023
@artonge artonge self-assigned this Sep 6, 2023
@artonge artonge mentioned this pull request Sep 6, 2023
Closed
@artonge artonge force-pushed the artonge/feat/enable_new_versioning_features branch from a05ce9b to 45447a0 Compare September 6, 2023 14:33
@artonge artonge force-pushed the artonge/feat/enable_new_versioning_features branch 6 times, most recently from 3ca48c1 to 5b7c45c Compare September 7, 2023 12:18
@artonge
Copy link
Contributor Author

artonge commented Sep 7, 2023

/backport to stable27

come-nc
come-nc reviewed Sep 7, 2023
View reviewed changes
lib/Migration/Version16000Date20230821085801.php Show resolved Hide resolved
lib/Versions/GroupVersion.php Show resolved Hide resolved
lib/Versions/GroupVersionEntity.php Outdated Show resolved Hide resolved
lib/Versions/VersionsBackend.php Show resolved Hide resolved
lib/Versions/VersionsBackend.php Show resolved Hide resolved
lib/Versions/VersionsBackend.php Outdated Show resolved Hide resolved
@artonge
Copy link
Contributor Author

artonge commented Sep 7, 2023

For the backport

  • Bump app version in info.xml to trigger the migration

@artonge
WIP
951cea3 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/enable_new_versioning_features branch from 5b7c45c to 951cea3 Compare September 7, 2023 13:51
@artonge artonge merged commit 10d4011 into master Sep 7, 2023
15 checks passed
@artonge artonge deleted the artonge/feat/enable_new_versioning_features branch September 7, 2023 19:53
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 7, 2023
Merged
This was referenced Sep 8, 2023
Closed
Closed
@juliusknorr juliusknorr mentioned this pull request Sep 8, 2023
Closed
artonge added a commit that referenced this pull request Sep 12, 2023
@artonge
Revert "Merge pull request #2543 from nextcloud/artonge/feat/enable_n…
2acd618 
…ew_versioning_features"

This reverts commit 10d4011, reversing
changes made to 1030b9b.
artonge added a commit that referenced this pull request Sep 12, 2023
@artonge
Revert "Merge pull request #2543 from nextcloud/artonge/feat/enable_n…
85f7118 
…ew_versioning_features"

This reverts commit 10d4011, reversing
changes made to 1030b9b.
This was referenced Sep 14, 2023
Closed
Closed
Closed
@solracsf solracsf mentioned this pull request Sep 18, 2023
Closed
@joshtrichards joshtrichards mentioned this pull request Oct 5, 2023
Closed
@XueSheng-GIT XueSheng-GIT mentioned this pull request Nov 6, 2023
Closed
@joshtrichards joshtrichards mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@artonge artonge

Labels
3. to review Items that need to be reviewed bug enhancement feature: versions Items related to file versioning php Items related to PHP updates and code issues
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Make persistent versioning available for groupfolders
3 participants
@artonge @AndyScherzinger @come-nc