Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: environment.yml name must be lowercase #2676

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Linting: environment.yml name must be lowercase #2676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01aa95b
add linting of environment.yml name lowercase
mirpedrol Jan 22, 2024
aae4801
[automated] Update CHANGELOG.md
nf-core-bot Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

### Linting

- environment.yml name must be lowercase ([#2676](https://github.com/nf-core/tools/pull/2676))

### Modules

- Fix linting of a pipeline with patched custom module ([#2669](https://github.com/nf-core/tools/pull/2669))
Expand Down
18 changes: 18 additions & 0 deletions nf_core/modules/lint/environment_yml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,21 @@ def environment_yml(module_lint_object: ComponentLint, module: NFCoreComponent)
module.environment_yml,
)
)

# Check that the name is lowercase
if env_yml["name"] == env_yml["name"].lower():
module.passed.append(
(
"environment_yml_name_lowercase",
"The module's `environment.yml` name is lowercase",
module.environment_yml,
)
)
else:
module.failed.append(
(
"environment_yml_name_lowercase",
"The module's `environment.yml` name is not lowercase",
module.environment_yml,
)
)
Loading