increase python max package rebuilds from 10 to 25 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure |
bhipple
approved these changes
Apr 11, 2020
|
Would it make sense to increase this to 500 to match the master branch cutoff (>500 goes to staging and skips nixpkgs-review)? cc @mweinelt |
|
I guess, but even 100 or 250 would be a cool upgrade. Really depends on how busy the builder behind this setup is. |
|
Apart from a bit of a slowdown while it is catching up with the newly allowed updates the builder should be fine. Something that may be an issue is nixpkgs-review step, currently it has a 45 minute timeout. I've opened a PR to increase it to 120 minutes, do you think that would be enough? |
|
Yeah, that would certainly do it, unless you run into any of the weird packages like tensorflow, torch or similar. |
|
Increasing the timeout and the python rebuilds are in #399. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonringer requested this change but he wanted me to cc @FRidh to make sure he's okay with it.