Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 100 #399

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 17, 2024

Recently we've been running nixpkgs-update on better hardware and have also increased the number of workers so I think it makes sense to increase this timeout.

Increasing the python rebuilds was discussed in #185.

I'll wait a week for comments before deploying this to build02. nix-community/infra#1169

@zowoq zowoq changed the title increase nixpkgs-review timeout to 120 minutes increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 500 Mar 17, 2024
@jonringer
Copy link
Contributor

The original thought process was that packages which have more than 25 rebuilds are much more likely to have downstream failures, thus better suited for the batch updates we do periodically.

That being said, I would be fine with bumping this to 50 or 100. But 500 is almost 10% of the python package set. Too much.

@zowoq
Copy link
Contributor Author

zowoq commented Apr 9, 2024

bumping this to 50 or 100

#185 (comment)
100 or 250 would be a cool upgrade

@mweinelt Are you still okay with 100?

@zowoq zowoq changed the title increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 500 increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 100 Apr 28, 2024
@zowoq zowoq merged commit fc6a441 into nix-community:main Apr 28, 2024
7 checks passed
@zowoq zowoq deleted the review-timeout branch April 28, 2024 02:15
@jonringer
Copy link
Contributor

Thanks for following up on this @zowoq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants