Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 100 #399

Merged
merged 2 commits into from
Apr 28, 2024
Merged

increase nixpkgs-review timeout to 120 minutes, increase python max package rebuilds from 25 to 100 #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2567085
increase nixpkgs-review timeout to 120 minutes
zowoq Mar 4, 2024
5b65371
increase python max package rebuilds from 25 to 100
zowoq Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/nixpkgs-maintainer-faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Updates can be disabled by adding a comment to the package:

We maintain a [Skiplist](https://github.com/ryantm/nixpkgs-update/blob/main/src/Skiplist.hs) of different things not to update. It is possible your package is triggering one of the skip criteria.

Python updates are skipped if they cause more than 25 rebuilds.
Python updates are skipped if they cause more than 100 rebuilds.

### Existing Open or Draft PR

Expand Down
2 changes: 1 addition & 1 deletion src/NixpkgsReview.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ run ::
Text ->
Sem r Text
run cache commit =
let timeout = "45m" :: Text
let timeout = "120m" :: Text
in do
-- TODO: probably just skip running nixpkgs-review if the directory
-- already exists
Expand Down
2 changes: 1 addition & 1 deletion src/Skiplist.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,4 @@ python numPackageRebuilds derivationContents =
(not isPython || numPackageRebuilds <= maxPackageRebuild)
where
isPython = "buildPythonPackage" `T.isInfixOf` derivationContents
maxPackageRebuild = 25
maxPackageRebuild = 100