Update scripts to allow extra flags. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saienduri
reviewed
Oct 4, 2024
saienduri
approved these changes
Oct 4, 2024
kuhar
reviewed
Oct 5, 2024
Yeah, that very unergnomic. I always felt its probably just an artifact how the CL parser is implemented. |
|
@saienduri this seems to be hitting some unrelated failure on CI. Could you please take a look? |
|
Sure, @MaheshRavishankar I have landed this PR (#11) which fixes the CI. Once you rebase, you should be good |
kuhar
reviewed
Oct 7, 2024
| default=[], | ||
| help="Extra command line arguments passed to the IREE compiler. This can be specified multiple times to pass multiple arguments." | ||
| help="Extra command line arguments passed to the IREE compiler. The flags need to be specified without the `--` or `-`" | ||
| ) | ||
| parser.add_argument( |
There was a problem hiding this comment.
If you change this one one, I think we should also change the two flags below to use nargs=+
There was a problem hiding this comment.
maybe... i dont know where all it is used. Could be a follow up.
Signed-off-by: MaheshRavishankar <mravisha@amd.com>
Signed-off-by: MaheshRavishankar <mravisha@amd.com>
…command` Signed-off-by: MaheshRavishankar <mravisha@amd.com>
Signed-off-by: MaheshRavishankar <mravisha@amd.com>
Signed-off-by: MaheshRavishankar <mravisha@amd.com>
Signed-off-by: MaheshRavishankar <mravisha@amd.com>
MaheshRavishankar
force-pushed
the
allow_ir_dump
branch
from
b20558e
to
4dc69c6
Compare
kuhar
added a commit
to kuhar/iree-kernel-benchmark
that referenced
this pull request
Oct 8, 2024
Use nargs=+ for data types and variants to align with extra compiler args. This is a follow up after nod-ai#10.
kuhar
added a commit
that referenced
this pull request
Oct 8, 2024
Use nargs=+ for data types and variants to align with extra compiler args. This is a follow up after #10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of changes in this PR
--Xiree_compilecan take now a list of flags to pass toiree-compilewithout having to specify--Xiree-compilemultiple times. Note that the flags passed toiree-compileshould not contain--stderrforrun_iree_commandand pass back to caller. This allows generating IR dumps.For example
--Xiree_compile mlir-disable-threading mlir-print-ir-before=<pass-list> mlir-print-ir-after=<pass-list>dumps IR before and after passes to*.stderr.mlir.