새로운 플레이어 아이템 들어오면 stop하던 로직 주석처리 #1080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
childc
reviewed
Sep 13, 2023
| @@ -518,7 +518,7 @@ private extension AudioPlayerAgent { | |||
| if let currentPlayer = self.currentPlayer, | |||
| player.shouldResume(player: currentPlayer) { | |||
| log.info("Resuming \(player.header.messageId)") | |||
| currentPlayer.stop() | |||
| // currentPlayer.stop() | |||
There was a problem hiding this comment.
요거 play directive들어오면 이전 player stop하는 코드 같은데
좀더 검토가 필요해보여요. 저도 계속 살펴볼게요
ParkJongSang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description