Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

새로운 플레이어 아이템 들어오면 stop하던 로직 주석처리 #1080

Closed
wants to merge 5 commits into from
Closed

새로운 플레이어 아이템 들어오면 stop하던 로직 주석처리 #1080

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ee32f5
AudioPlayer2Template 파싱코드 생성
ParkJongSang Sep 12, 2023
87ea56c
handlePlay에 Play하는 코드 추가
ParkJongSang Sep 13, 2023
a026820
테스트코드 원상복구
ParkJongSang Sep 13, 2023
c67a0ba
Stop해주는 부분 제거
ParkJongSang Sep 13, 2023
c015a59
Template2관련 코드 제거
ParkJongSang Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NuguAgents/Sources/CapabilityAgents/AudioPlayer/AudioPlayerAgent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ private extension AudioPlayerAgent {
if let currentPlayer = self.currentPlayer,
player.shouldResume(player: currentPlayer) {
log.info("Resuming \(player.header.messageId)")
currentPlayer.stop()
// currentPlayer.stop()
Copy link
Contributor

@childc childc Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 play directive들어오면 이전 player stop하는 코드 같은데
좀더 검토가 필요해보여요. 저도 계속 살펴볼게요

player.replacePlayer(currentPlayer)
}
self.currentPlayer = player
Expand Down
6 changes: 6 additions & 0 deletions NuguClientKit/Sources/Audio/ControlCenterManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,12 @@ private extension ControlCenterManager {
return nil
}
return (payload.template.content.title, payload.template.content.subtitle1, payload.template.content.subtitle2, payload.template.content.imageUrl)
case "AudioPlayer.Template2":
guard let payload = try? JSONDecoder().decode(AudioPlayer2Template.self, from: payloadAsData) else {
remove()
return nil
}
return (payload.template.content.title, payload.template.content.subtitle, payload.template.content.subtitle1, payload.template.content.imageUrl)
default:
remove()
return nil
Expand Down