Contract Update Validator #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act-upgrade-checker
dsainati1
commented
Feb 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
+ Coverage 80.65% 80.67% +0.02%
==========================================
Files 379 380 +1
Lines 91494 91743 +249
==========================================
+ Hits 73797 74018 +221
- Misses 15049 15069 +20
- Partials 2648 2656 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e into sainati/contract-upgrade-checker
…e into sainati/contract-upgrade-checker
…e into sainati/contract-upgrade-checker
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit f4fdbc6 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
reviewed
Feb 13, 2024
SupunS
force-pushed
the
sainati/contract-upgrade-checker
branch
from
fadbc8d
to
38c9977
Compare
|
Is this only for staged updates?
this may be storage breaking I guess.
related to this, what happens to existing fields like @FungibleToken.Vault types etc ? they need to be able to change to @{FungibleToken.Vault} no ? |
SupunS
force-pushed
the
sainati/contract-upgrade-checker
branch
from
38c9977
to
ecb5e3c
Compare
Yes.
How come? do you have an example? |
If I had let's say: [{I}] and put inside A:I , now after update I can still validly keep [{I}] but it will contain A which not implementing I no? |
|
ahh I see. Thanks for flagging! |
Yes, correct. |
SupunS
force-pushed
the
sainati/contract-upgrade-checker
branch
from
64f2274
to
9bc54ff
Compare
SupunS
force-pushed
the
sainati/contract-upgrade-checker
branch
from
9bc54ff
to
67411cb
Compare
…ti/contract-upgrade-checker
6 tasks
turbolent
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2865
A more permissive contract upgrade validator for converting v0.42 contracts to v1.0
This includes:
R{I}restricted type in a field annotation must be replaced with anRtype&Treference type may be granted any set of entitlements less permissive than the actual set thatTsupports according to the entitlements migration.masterbranchFiles changedin the Github PR explorer