-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: chore(nbcs): update tooling in controller's Makefiles - kubernetes and kustomize #432
base: main
Are you sure you want to change the base?
Conversation
The version 1.23 is no longer supported [1] and only releases from 1.28 - 1.31 versions are supported. Based on the [2], the OpenShift 4.13 (oldest we care about right now) is based on Kubernetes in version 1.26, so let's allign to that version. * [1] https://kubernetes.io/releases/ * [2] https://access.redhat.com/solutions/4870701
This is a followup of opendatahub-io#391 (1b2dd4f). Without this, we can see the following failure during the e2e tests execution: ``` make run-ci-e2e-tests ... GOBIN=/home/jstourac/workspace/rhosai/odh/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2 go: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: invalid version: unknown revision v3/cmd/kustomize/v5.0.2 make[1]: *** [Makefile:243: kustomize] Error 1 ... ``` This caused that all e2e tests failed. After this fix, some e2e tests pass. The other seem to fail on a problem unrelated to this one.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm What's that we need to be running in ci and we aren't? Because, both GitHub actions and ocp-ci are passing now, right? Bit the customize line is clearly wrong... |
Hm, but we're not running e2e tests anywhere in our CI here in GitHub, are we? I didn't investigate the failure very much, I can do so later maybe. |
The e2e that need you to bring your own openshift? Right, we don't run that in gha ci. We should, eventually. Thought it runs in ocp či, but apparently really not. |
Hm, @jiridanek you are right, we're truly running them: https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml#L107. And it is green in your PR #430 (this run) even though they failed, see the results here:
We probably don't propagate the return code in that place properly or don't fail as we should. My run here failed even before the e2e tests were triggered, so I'll try to re-run it to see whether I'll see what I saw during my local testing: /retest |
I raised the #433 to address this issue. Also created https://issues.redhat.com/browse/RHOAIENG-15141 to track these E2E test failures so we can plan on it.
So, retest didn't work - the failure was the very same and again - it even didn't get to the point of the tests execution --- no e2e directory in here. This is the failure, something related to the cluster preparation:
|
Let’s try again /retest |
@jstourac: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Some tooling updates and fix. I bumped into this during my work on https://issues.redhat.com/browse/RHOAIENG-14687.
This fix is part of https://issues.redhat.com/browse/RHOAIENG-15141.
Description
The update of the kubernetes version isn't mandatory and I can remove it from here if you want to. But I think it's reasonable.
The fix for the kustomize package is necessary to make our e2e tests pass (at least partially) again. This change is a followup of the #391.
How Has This Been Tested?
Try to run in
components/odh-notebook-controller
:make test
- all should pass.make run-ci-e2e-tests
- 15 pass, 2 fail - you need to be logged into some cluster to make this workMerge criteria: