[Fix] update bash scripts for E2E tests run to propagate failures #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't been propagating the test failures in our E2E CI jobs because we weren't checking for the return codes of the commands run in the bash scripts.
This depends on #432!
I bumped into this during my work on https://issues.redhat.com/browse/RHOAIENG-14687.
This fix is part of https://issues.redhat.com/browse/RHOAIENG-15141.
Description
How Has This Been Tested?
Try to run in
components/odh-notebook-controller
:make run-ci-e2e-tests
- 15 pass, 2 fail - you need to be logged into some cluster to make this workMerge criteria: