Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enocean] D2-01-0C implement support for pilot wire mode #17450

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lovery
Copy link
Contributor

@lovery lovery commented Sep 20, 2024

Refs #6938

I haven't tested this code because I don't have such a device, so please wait until someone with such a device test it and confirm that everything works.

Test jar file here

Rename constants name from *RESPONE to *RESPONSE

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
Refs openhab#6938

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Sep 21, 2024
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Sep 21, 2024
@jlaur jlaur changed the title [enocean]: D2-01-0C implement support for pilot wire mode [enocean] D2-01-0C implement support for pilot wire mode Sep 21, 2024
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 22, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Sep 22, 2024

Would you be able to frix the DCO?

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
@dilyanpalauzov
Copy link
Contributor

As this is touching the D2-01-0C device type, can you make its description in enocean.properties and MeasurementSwitch more unique from the other descriptions? (It appears twice in each file). The current description is “Switching and energy measurement (EEP: D2_01_0C)”. Looking at the table on page 132 of https://www.enocean-alliance.org/wp-content/uploads/2017/05/EnOcean_Equipment_Profiles_EEP_v2.6.7_public.pdf, you could add “power” (as some D2-01 devices have/do not have this element), and “pilot wire” (as only D2-01-0C) has it. The purpose of writing more precise text is to make it more distinguishable for users from the other device types.

@dilyanpalauzov
Copy link
Contributor

I have updated at #17522 the description for D2-01-0C and other devices. I kept there receivingEEPId and sendingEEPId are identical. I do not know if this is correct.

@dilyanpalauzov
Copy link
Contributor

I haven't tested this code because I don't have such a device

You can ask in the OpenHAB Forum - https://community.openhab.org/ - if somebody can test this.

@lsiepel lsiepel linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enocean] Add support for pilot wire mode
4 participants