Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JUnit 4 dependencies #17580

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove JUnit 4 dependencies #17580

merged 1 commit into from
Oct 17, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Oct 16, 2024

Using JUnit 5 should suffice.

@wborn
Remove JUnit 4 dependencies
1cd5c6b 
Using JUnit 5 should suffice.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner October 16, 2024 20:26
@wborn wborn mentioned this pull request Oct 16, 2024
Closed
lsiepel
lsiepel approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I’ll pay extra attention to this

@lsiepel lsiepel merged commit 65004e5 into openhab:main Oct 17, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 17, 2024
@wborn wborn deleted the remove-junit-4-deps branch October 17, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @lsiepel