Add transfers for using arguments #16
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I'd prefer to keep Can we move this visitor into a either the existing |
nielsdebruin
force-pushed
the
transfer-using
branch
from
a24ce0d
to
725e9d0
Compare
...java/org/openrewrite/java/jackson/codehaus/TransferUsingArgumentFromCodehausToFasterXML.java
Outdated
Show resolved
Hide resolved
...java/org/openrewrite/java/jackson/codehaus/TransferUsingArgumentFromCodehausToFasterXML.java
Outdated
Show resolved
Hide resolved
nielsdebruin
changed the title
timtebeek
changed the title
...java/org/openrewrite/java/jackson/codehaus/TransferUsingArgumentFromCodehausToFasterXML.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openrewrite/java/jackson/codehaus/RemoveDoublyAnnotatedCodehausAnnotations.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Thanks for the work & rework here @nielsdebruin ; ended up removing the troublesome auto format; when in doubt that's typically easiest.
| @JsonSerialize(include = NON_NULL, using = None.class) | ||
| @com.fasterxml.jackson.databind.annotation.JsonSerialize(using = None.class) |
There was a problem hiding this comment.
What I found slightly odd about the "after" usage example here is that we're one-to-one moving the argument over, whereas the using argument here, as well as the contentUsing, keyUsing and nullsUsing sibling only accept a FasterXml JsonSerializer, whereas the moved argument is a Codehaus JsonSerialzer, That means after this recipe the code would not yet compile. Compare the before and after packages:
That means we likely need to expand the converted packages (ideally) and types (for exceptional cases) seen here:
On it |
| // Map from codehaus -> fasterxml annotation | ||
| Map<J.Annotation, J.Annotation> doubleAnnotated = new FindDoublyAnnotatedVisitor().reduce(tree, new HashMap<>()); | ||
|
|
||
| transferArgument(doubleAnnotated, "using"); |
There was a problem hiding this comment.
Perhaps we could keep a list of field names that should be transferred and reduce this to a single statement?
What's changed?
The
RemoveDoublyAnnotatedCodehausAnnotationsrecipe has been extended with the functionality to transfer the value of "using" in the codehaus annotations@JsonSerialize(using=XYZ)to the faster XML annotation.The transfer only occurs if no value forusinghas been specified in the fasterxml annotation. An option has been added to enable or disable this behaviorAnything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@Laurens-W @timtebeek
Checklist