Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transfers for using arguments #16
base: main
Are you sure you want to change the base?
Add transfers for using arguments #16
Changes from 5 commits
725e9d0
9a49630
b5fab13
dd18d98
fde7ea8
736fce0
70ab8c7
9069316
4dba8b5
cfb95b3
d9b39b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I found slightly odd about the "after" usage example here is that we're one-to-one moving the argument over, whereas the
using
argument here, as well as thecontentUsing
,keyUsing
andnullsUsing
sibling only accept a FasterXml JsonSerializer, whereas the moved argument is a Codehaus JsonSerialzer, That means after this recipe the code would not yet compile. Compare the before and after packages:That means we likely need to expand the converted packages (ideally) and types (for exceptional cases) seen here:
rewrite-jackson/src/main/resources/META-INF/rewrite/codehaus-to-fasterxml.yml
Lines 32 to 62 in b5fab13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed up in 736fce0.