Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add set processor documentation #5989

Merged
merged 13 commits into from
Jun 10, 2024
Merged

[DOC] Add set processor documentation #5989

merged 13 commits into from
Jun 10, 2024

Conversation

vagimeli
Copy link
Collaborator

Description

Closes content gap

Issues Resolved

#4647

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli self-assigned this Dec 22, 2023
@vagimeli vagimeli added Needs SME Waiting on input from subject matter expert Content gap labels Dec 22, 2023
@vagimeli
Copy link
Collaborator Author

@hdhalter We need a dev to take the first pass at drafting this content. I can support them in refining the content and getting it through the documentation process. The ingest processor template is provided with this PR, so it should help the dev get started. Thanks!

@vagimeli vagimeli marked this pull request as draft February 15, 2024 21:22
@vagimeli vagimeli marked this pull request as ready for review May 28, 2024 20:35
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added the backport 2.14 PR: Backport label for 2.14 label May 28, 2024
@vagimeli
Copy link
Collaborator Author

@gaobinlong This PR is ready for your review at your availability. Thank you for all your technical reviews on these topics!

@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress and removed Needs SME Waiting on input from subject matter expert labels May 30, 2024
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

# Set processor

The `set` processor adds or updates fields in a document. It sets one field and associates it with the specified value. If the field already exists, its value is replaced with the provided one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the field already exists, its value is replaced with the provided one

This is not always true, because if the parameter override is set to false and the specified field exists, the value of the field will not change.

_ingest-pipelines/processors/set.md Outdated Show resolved Hide resolved
`field` | Required | The name of the field to be set or updated. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets).
`value` | Required | The value to be assigned to the field. Supports [template snippets]({{site.url}}{{site.baseurl}}/ingest-pipelines/create-ingest/#template-snippets).
`overrideEnabled` | Optional | A Boolean flag that determines whether the processor should override the exisitng value of the field.
`ignoreEmptyValue` | Optional | A Boolean flag that determines whether the processor should ignore empty values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoreEmptyValue should be ignore_empty_value, defaults to false, empty value means null or empty string.

_ingest-pipelines/processors/set.md Outdated Show resolved Hide resolved
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels Jun 7, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my changes and let me know if you have any questions. Thanks!

_ingest-pipelines/processors/set.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/set.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/set.md Outdated Show resolved Hide resolved
vagimeli and others added 4 commits June 10, 2024 08:11
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli removed the 5 - Editorial review PR: Editorial review in progress label Jun 10, 2024
@vagimeli
Copy link
Collaborator Author

@natebower Thank you for the thorough review. I've accepted your edits. Will you approve for merging? This is part of the series that I opened PRs and co-authored with dev, but can't approve. Thank you.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli merged commit 7df5fee into main Jun 10, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
* Add set processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* add text and examples

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* add text and examples

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 7df5fee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RasonJ pushed a commit to o19s/documentation-website that referenced this pull request Jun 12, 2024
* Add set processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* add text and examples

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* add text and examples

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

* Update _ingest-pipelines/processors/set.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: RasonJ <145287540+RasonJ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.14 PR: Backport label for 2.14 Content gap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants