Update base java image to amazoncorretto:11-al2023-headless #635
Conversation
AndreKurait
requested review from
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
| @@ -57,8 +57,8 @@ class CommonUtils { | |||
| runCommand("sed -i -e \"s|mirrorlist=|#mirrorlist=|g\" /etc/yum.repos.d/CentOS-* ; sed -i -e \"s|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g\" /etc/yum.repos.d/CentOS-*") | |||
| runCommand("yum -y install nmap-ncat") | |||
| } else { | |||
| from 'openjdk:11-jre' | |||
| runCommand("apt-get update && apt-get install -y netcat") | |||
There was a problem hiding this comment.
I don't believe that we need netcat any more.
There was a problem hiding this comment.
Agreed, I'd be surprised if we were using this anywhere and should probably remove
| @@ -1,5 +1,5 @@ | |||
| # Using same base image as other Java containers in this repo | |||
| FROM openjdk:11-jre | |||
| FROM amazoncorretto:11-al2023-headless | |||
There was a problem hiding this comment.
I think you mentioned this before but I can't remember... Are we in any better position if we pull from ECR versus Docker
There was a problem hiding this comment.
This isn't ECR, this is the docker hub hosted corretto version.
Before using ECR, we should add aws credentials to our actions
Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
AndreKurait
force-pushed
the
FixDeprecatedImage
branch
from
db1f7da
to
eee8d47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
============================================
- Coverage 75.84% 75.59% -0.25%
+ Complexity 1545 1539 -6
============================================
Files 168 168
Lines 6446 6446
Branches 574 574
============================================
- Hits 4889 4873 -16
- Misses 1177 1192 +15
- Partials 380 381 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Update base java image to amazoncorretto:11-al2023-headless removing deprecated openjdk:11-jre
Issues Resolved
MIGRATIONS-1724
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Docker Solution startup and integration tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.