-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base java image to amazoncorretto:11-al2023-headless #635
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,10 +55,8 @@ class CommonUtils { | |
from "migrations/${dependentDockerImageName}:${hashNonce}" | ||
dependsOn "buildDockerImage_${baseImageOverrideProjectName}" | ||
runCommand("sed -i -e \"s|mirrorlist=|#mirrorlist=|g\" /etc/yum.repos.d/CentOS-* ; sed -i -e \"s|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g\" /etc/yum.repos.d/CentOS-*") | ||
runCommand("yum -y install nmap-ncat") | ||
} else { | ||
from 'openjdk:11-jre' | ||
runCommand("apt-get update && apt-get install -y netcat") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't believe that we need netcat any more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, I'd be surprised if we were using this anywhere and should probably remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||
from 'amazoncorretto:11-al2023-headless' | ||
} | ||
|
||
copyFile("jars", "/jars") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mentioned this before but I can't remember... Are we in any better position if we pull from ECR versus Docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't ECR, this is the docker hub hosted corretto version.
Before using ECR, we should add aws credentials to our actions