For miwi use user delegated sas to allow bootstrap node to pull the ignition #186
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rajdeepc2792 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rajdeepc2792
force-pushed
the
ARO-9712-for-miwi-use-user-delegated-SAS
branch
from
999c202
to
213da15
Compare
rajdeepc2792
force-pushed
the
ARO-9712-for-miwi-use-user-delegated-SAS
branch
from
213da15
to
fb1d7be
Compare
|
@rajdeepc2792: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| } | ||
| currentTime := time.Now().UTC().Add(-10 * time.Second) | ||
| expiryTime := time.Now().UTC().Add(time.Hour) | ||
| perms := sas.BlobPermissions{Read: true} |
There was a problem hiding this comment.
I noticed that for CSP clusters we give "read" and "list", so why does only "read" work here?
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-9712 in combination with ARO-RP PR:- Azure/ARO-RP#3894
What this PR does / why we need it:
For MIWI:
Test plan for issue:
[x] Test the flow of cluster install such that the Shared Access Keys are disabled.
[x] Test the flow of cluster install such that the Cluster Service Principal Cluster are created correctly.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
/cherrypick release-4.15 release-4.14