Spinner, toaster notes, date & time picker factories unit tests updates #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into feature/testing_tuesday
…client-native-form into feature/testing_tuesday
dubdabasoduba
changed the title
dubdabasoduba
changed the title
…ure/testing_tuesday
…client-native-form into feature/testing_tuesday
bennsimon
requested changes
Nov 4, 2020
|
|
||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public class ToasterNotesFactoryTest extends BaseTest { |
There was a problem hiding this comment.
extend FactoryTest instead, remove the JsonFormActivity declaration and assignment call super on setUp
|
|
||
| import java.util.List; | ||
| import java.util.Locale; | ||
| import java.util.Set; | ||
|
|
||
| public class TimePickerFactoryTest extends BaseTest { |
There was a problem hiding this comment.
extend FactoryTest instead, remove the JsonFormActivity declaration and assignment call super on setUp
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Created by Vincent Karuri on 03/04/2020 | ||
| */ | ||
| public class SpinnerFactoryTest extends BaseTest { |
There was a problem hiding this comment.
extend FactoryTest instead, remove the JsonFormActivity declaration and assignment call super on setUp
…ient-native-form into feature/testing_tuesday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.