Update JEASY MVEL dependencies to fix security vulnerabilities #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekigamba
changed the title
ekigamba
changed the title
ekigamba
commented
Nov 21, 2022
| @@ -1427,7 +1428,13 @@ private Facts getEntries(String[] address, JSONObject object) throws JSONExcepti | |||
| formObject.put(RuleConstant.IS_RULE_CHECK, true); | |||
| formObject.put(RuleConstant.STEP, formObject.getString(RuleConstant.STEP)); | |||
|
|
|||
| result.asMap().putAll(getValueFromAddressCore(formObject).asMap()); | |||
|
|
|||
| Facts resultFacts = getValueFromAddressCore(formObject); | |||
There was a problem hiding this comment.
So this fixes an issue where comparison values were not available
ekigamba
commented
Dec 19, 2022
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Rule rule, Facts facts, Exception exception) { | ||
| //Overriden | ||
| Timber.e("Putting facts in onFailure"); |
There was a problem hiding this comment.
Kindly check if there might be successful executions of rules meaning that we might need to update our facts object with key-values from the facts.facts map
|
@junaidwarsivd Kindly push your latest changes and fix the build in this PR |
to local snapshot on which the jackson dependency is updated
…erability-upgrade
…ated it needs the Extended version of YamlRuleDefinitionReader
ekigamba
commented
Mar 3, 2023
| @@ -27,8 +29,16 @@ public class AssetsFileSource implements FormFileSource { | |||
| private MVELRuleFactory mvelRuleFactory; | |||
|
|
|||
| private AssetsFileSource() { | |||
| if(Utils.enabledProperty(NativeFormsProperties.KEY.EASY_RULES_V3_COMPATIBILITY)) | |||
There was a problem hiding this comment.
Fix the formatting and/or spacing in the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.