-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup hlo_extractor and hlo_bisect dependecies #18170
Conversation
//xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@@ -42,7 +42,6 @@ limitations under the License. | |||
#include "xla/service/hlo_verifier.h" | |||
#include "xla/shape.h" | |||
#include "xla/shape_util.h" | |||
#include "xla/tests/test_utils.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add xla/literal_util.h include instead. Also the corresponding BUILD dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already added in line 39. And the dependency also exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I should have expanded the view to see it.
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686086772
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686086772
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686086772
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686086772
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686086772
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686086772
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686421179
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686421179
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686421179
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686421179
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 PiperOrigin-RevId: 686444491
//xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util.