Cleanup hlo_extractor and hlo_bisect dependecies #18170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util.
akuegel
approved these changes
Oct 15, 2024
| @@ -42,7 +42,6 @@ limitations under the License. | |||
| #include "xla/service/hlo_verifier.h" | |||
| #include "xla/shape.h" | |||
| #include "xla/shape_util.h" | |||
| #include "xla/tests/test_utils.h" | |||
There was a problem hiding this comment.
Please add xla/literal_util.h include instead. Also the corresponding BUILD dependency.
There was a problem hiding this comment.
It is already added in line 39. And the dependency also exists.
There was a problem hiding this comment.
Ah, sorry, I should have expanded the view to see it.
akuegel
approved these changes
Oct 16, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686086772
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686086772
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686086772
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686086772
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686086772
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686086772
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686421179
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686421179
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR #18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566 by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566 PiperOrigin-RevId: 686421179
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#18170 from shraiysh:cleanup_extractor_deps 133e566a2b3e82c81d014b289ddc60bea9c629de PiperOrigin-RevId: 686421179
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 16, 2024
Imported from GitHub PR openxla/xla#18170 //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Copybara import of the project: -- 133e566a2b3e82c81d014b289ddc60bea9c629de by Shraiysh Vaishay <svaishay@nvidia.com>: Cleanup hlo_extractor and hlo_bisect dependecies //xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util. Merging this change closes #18170 PiperOrigin-RevId: 686444491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util.